[WIP] enhance unit testing #4597
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also checks basic file reading and writing.
Codecov Report
@@ Coverage Diff @@
## master #4597 +/- ##
============================================
+ Coverage 10.90% 11.16% +0.25%
Complexity 1044 1044
============================================
Files 277 277
Lines 35626 35627 +1
Branches 7852 7852
============================================
+ Hits 3886 3976 +90
+ Misses 31520 31431 -89
Partials 220 220
|
Rearranged the lines alphabetically to better compare it with the source files.
Also uses EXPECT_instead of ASSERT_ because with ASSERT_ the test immediately stops not executing the remaining tests of a suite. It's better to execute all tests and get a better picture what is failing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some simple enhancements to unit testing. Still WIP.
Description of the Change
More unit testing of library functions.
Alternate Designs
Alternatively one could add the reference files to git and copy them into the directory where tests are executed but that seemed more work than reading and writing directly from within the test.
Release Notes
N/A